Use plotted gerbers when eda is available
#458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kasbah, I am not sure how to test this tough. I want to make sure it generated the right |
|
Could use a visual test but I'm not sure if the effort is worth it. |
AbdulrhmnGhanem
force-pushed
the
plotted-gerbers
branch
from
4d1ccbb
to
d49bf4f
Compare
I managed to get a consistent hash of the images in dcfa58f. |
AbdulrhmnGhanem
force-pushed
the
plotted-gerbers
branch
3 times, most recently
from
f7ee772
to
98969e5
Compare
kasbah
reviewed
Nov 2, 2022
This comment was marked as outdated.
This comment was marked as outdated.
AbdulrhmnGhanem
force-pushed
the
plotted-gerbers
branch
from
98969e5
to
cc4864f
Compare
kasbah
reviewed
Nov 4, 2022
AbdulrhmnGhanem
force-pushed
the
plotted-gerbers
branch
from
d793ca6
to
224479e
Compare
- Also, changed the compiler target to es6 to be able to use `Array.entries` (used in the test).
AbdulrhmnGhanem
force-pushed
the
plotted-gerbers
branch
from
224479e
to
36e936e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455