-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme processing #419
Merged
Merged
Readme processing #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulrhmnGhanem
force-pushed
the
readme-processing
branch
from
September 22, 2022 11:26
e727741
to
c90e5d4
Compare
(cherry picked from commit 0a79953)
(cherry picked from commit 55ef041)
- Some projects use html in the readme, to fix the links in this case we will end up using cheerio again. - `remark` on the other hand supports overriding html by a simple plugin `urlTansformer`.
- We were relying in a legacy behavior on gitea to redirect `/raw/` requets to the default branch. - But if there is a branch with the same name of the file in `/raw/{file_path...}` it will redirect to the branch. - This commit uses the default branch to avoid accidental redirects.
AbdulrhmnGhanem
force-pushed
the
readme-processing
branch
from
September 26, 2022 12:43
c90e5d4
to
2ae64a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
esp8266-breakout
and others URLs in readme is treated as normal text #349abdo-dev.staging.kitspace.dev/readme/esp8266-breakout
Fixes
Openspritzer
and others readme images uses non-raw absolute Github URL #373https://abdo-dev.staging.kitspace.dev/readme/Openspritzer
Fixes
antenna-analyser
readme text layout isn't consistent with Github #382abdo-dev.staging.kitspace.dev/readme/antenna-analyser
Fixes Missing page readme anchors in
OtterPill
#358Fixes
tomu
readme images layout #383Fixes
RB3200-ESP32universal
readme text layout #384Fixes
NodeMCU_IR
readem images uses file paths #385Fixes
NodeMCU_PIS
readme code block style #386After adding rehype-highlight