Handle registry boards in processor #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulrhmnGhanem
force-pushed
the
ag/import-registry
branch
from
aabf3cb
to
9412fa7
Compare
kasbah
requested changes
Jul 2, 2023
processor/src/queues.ts
Outdated
Comment on lines
187
to
190
| if (registryHash) { | ||
| // no need to pull if we aren't going to use the latest commit | ||
| done() | ||
| } |
There was a problem hiding this comment.
But you are still pulling below, you are just releasing the lock early?
There was a problem hiding this comment.
Resolved in 68230b6.
kasbah
reviewed
Jul 2, 2023
kasbah
reviewed
Jul 2, 2023
Co-authored-by: Kaspar Emanuel <kaspar.emanuel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried three approaches to handle the registry boards:
clone the repo, checkout the hash, create an empty gitea repo, and push to gitea (the most complicated)
migrate the repo, clone it, and change the default branch, and push
checkout the hash in the processor (the cleanest)
I settled for making the processor handle the registry boards.