fix for issue 10 #11
Closed
fix for issue 10 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for adding this. |
kittinunf
requested changes
Sep 4, 2018
| @@ -16,5 +16,7 @@ class MemCache { | |||
|
|
|||
| fun remove(key: Any): Boolean = cache.remove(key) != null | |||
|
|
|||
| override fun sizeOf(key: String, value: Bitmap): Int = value.byteCount / 1024 | |||
There was a problem hiding this comment.
I think you need an import statement as well. Have you try to build this?
|
Let me close this and start with clean slate ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues building, so you probably want to verify this works and doesn't create any unintended consequences, but it was such a small change I figured it was worthwhile to PR.
HTH