-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup refreshVersions #811
Conversation
@@ -1,7 +1,7 @@ | |||
dependencies { | |||
api(project(Fuel.name)) | |||
|
|||
api(KotlinX.Coroutines.jvm) | |||
api(Kotlinx.Coroutines.jvm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change was needed because the plugin embed two top-level objects with the name AndroidX
and KotlinX
, that clash with the two same objects defined in the buildSrc
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
============================================
+ Coverage 71.75% 72.80% +1.04%
Complexity 302 302
============================================
Files 61 58 -3
Lines 1519 1489 -30
Branches 216 214 -2
============================================
- Hits 1090 1084 -6
+ Misses 316 295 -21
+ Partials 113 110 -3
Continue to review full report at Codecov.
|
Resolves #810
Description
Set up the project with gradle refreshVersions to make it easier to upgrade dependency versions
Help needed
I had to upgrade to Gradle 6.9
The plugin jacoco-android was incompatible with it, since I'm unfamiliar with it, I couldn't solve the problem easily. Help would be appreciated here.
Also, there is one test failing, and I don't know why, I verified that I didn't change the version of coroutines
Type of change
Check all that apply
How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist: