Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup refreshVersions #811

Closed
wants to merge 5 commits into from
Closed

Conversation

jmfayard
Copy link

@jmfayard jmfayard commented May 27, 2021

Resolves #810

Description

Set up the project with gradle refreshVersions to make it easier to upgrade dependency versions

Help needed

I had to upgrade to Gradle 6.9

The plugin jacoco-android was incompatible with it, since I'm unfamiliar with it, I couldn't solve the problem easily. Help would be appreciated here.

Also, there is one test failing, and I don't know why, I verified that I didn't change the version of coroutines

com.github.kittinunf.fuel.core.requests.CancellableRequestTest > testCancellationInline FAILED
    java.lang.AssertionError at CancellableRequestTest.kt:124

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@jmfayard jmfayard changed the title Refresh versions Setup refreshVersions May 27, 2021
@@ -1,7 +1,7 @@
dependencies {
api(project(Fuel.name))

api(KotlinX.Coroutines.jvm)
api(Kotlinx.Coroutines.jvm)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was needed because the plugin embed two top-level objects with the name AndroidX and KotlinX, that clash with the two same objects defined in the buildSrc

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #811 (8b2357d) into master (823df71) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #811      +/-   ##
============================================
+ Coverage     71.75%   72.80%   +1.04%     
  Complexity      302      302              
============================================
  Files            61       58       -3     
  Lines          1519     1489      -30     
  Branches        216      214       -2     
============================================
- Hits           1090     1084       -6     
+ Misses          316      295      -21     
+ Partials        113      110       -3     
Impacted Files Coverage Δ
...ava/com/github/kittinunf/fuel/stetho/StethoHook.kt
.../kittinunf/fuel/android/util/AndroidEnvironment.kt
...com/github/kittinunf/fuel/livedata/FuelLiveData.kt

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823df71...8b2357d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use refreshVersions?
1 participant