Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Headers on Get #858

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Add Headers on Get #858

merged 1 commit into from
Apr 19, 2023

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented Apr 17, 2023

This was one suggestion from #857

@iNoles iNoles self-assigned this Apr 17, 2023
@iNoles iNoles requested a review from kittinunf April 17, 2023 13:26
kittinunf
kittinunf approved these changes Apr 19, 2023
View reviewed changes
Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@kittinunf
Copy link
Owner

Can we add unit test quickly for this too? We also can do it in a separate PR.

@iNoles
Copy link
Collaborator Author

iNoles commented Apr 19, 2023

Can we add unit test quickly for this too? We also can do it in a separate PR.

Sure, I would have to do it another day. I don't mind if you do it if you have time.

@iNoles iNoles merged commit c431787 into main Apr 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the header-get branch April 19, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittinunf kittinunf kittinunf approved these changes

Assignees

@iNoles iNoles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iNoles @kittinunf