Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reading/saving of current layout to URL #17

Open
kittsville opened this issue Jul 31, 2015 · 3 comments
Open

Add reading/saving of current layout to URL #17

kittsville opened this issue Jul 31, 2015 · 3 comments

Comments

@kittsville
Copy link
Owner

The app URL should include the current layout's slug. When the site is visted the slug should be read and, if the layout exists, that layout should be switched to.

Some fancy stuff using history push state could be used but the simplest way would just do the above. Any implementation that did use push state should try to keep Chomskey gracefully deprecating and disabling that functionality on init if not supported.

While this would be useful, there are (currently) much more important issues to be solved.

@kittsville
Copy link
Owner Author

This would actually be really useful for development, removing low-priority tag.

@kittsville
Copy link
Owner Author

This is definitely coming next after #7. It's getting very tiresome to use that dropdown after every minor change.

@kittsville kittsville self-assigned this Aug 27, 2015
kittsville added a commit that referenced this issue Aug 27, 2015
Allows for locally loaded layout to be directly accessed via its URL #17
@kittsville
Copy link
Owner Author

Unfortunately the # can't be removed once it's been added. I could look into using .htaccess to resolve non-'assets' directories to layout parameters to pass to Chomskey and use HTML5 history pushstates to update the URL as the layout is changed without reloading the page, but that seems like a lot of effort for little gain.

I'm tempted to close this issue as is. I'll leave it open to ponder on.

@kittsville kittsville removed their assignment Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant