Issue 617 clipdf #631
Merged
Issue 617 clipdf #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move binary 0/1 prediction to functions in `metrics` module
by default now only returns clip_df. If user specifies `return_unsafe_samples=True`, will return unsafe samples as a second return value. Also, now supports labels. If passed a dataframe with file paths as index and labels as values (one column per class, 0/1 values), it will copy the values from each file to all clips belonging to that file in the resulting clip df. Note that if the label df passed has duplicated paths in the index, only the _first_ row for any unique path is used as the labels in the resulting clip_df.
for safe dataset and other variable names, use 'invalid' rather than 'unsafe' to indicate samples that failed to preprocess. Similarly, use 'valid' rather than 'safe'.
Makes sense to only track unique values of paths that caused preprocessing errors. Resolves unsafe samples should be set #630
- remove comments refering to returned predictions - remove argument `threshold` in .predict()
was allowing attempt to write metadata with non-allowed formats because of logical error in the if statement
also remove outdated `threshold` args in tests
pass return_invalid_samples=True to .predict() to return a set of paths for files that failed to preprocess. Includes a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #617, #589, and #630 by refactoring make_clip_df and related code
Also contains a bug fix that should have been in another branch: workaround for librosa/soundfile trying to load float32 from mp3 and getting empty sample array