Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 636 one output node for single-class classification #641

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

sammlapp
Copy link
Collaborator

We choose to use the convention that one-class problems should have a CNN architecture with one output node. In the past, we often used two nodes for such "binary" classification problems ("present" and "absent") with a softmax layer, but this is confusing and doesn't make much sense. Resolves #636 and #495 - in which having two classes for a one-class model caused misleading metrics (eg, averaged precision across the "present" and "absent" classes)

we used to use 2 outputs for "binary" classificaiton tasks, but we choose the convention of using 1 output node for 1 class problems going forward.
Sometimes this line seems to be needed, sometimes it doesnt(?) Commenting the line out avoids an error when I run the notebook, though the test in test_cnn.py runs without error with or without the line.
@sammlapp sammlapp changed the base branch from master to develop January 10, 2023 19:55
@sammlapp sammlapp merged commit 38f274a into develop Jan 10, 2023
@sammlapp sammlapp deleted the issue_636_one_out branch January 10, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use one-output models for binary classifcation
1 participant