Changes in oauth2:refresh_access_token #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| %% @doc Verifies that Scope is a valid scope of the set of scopes defined | ||
| %% by ValidScopes. | ||
| %% @end | ||
| -callback verify_scope(ValidScopes, Scope) -> {ok, Scope2} | {error, Reason} when |
There was a problem hiding this comment.
I needed to add another verify_scope function to check the requested scope with that associated with the refresh token, see line 311 in oauth2.erl. I looked for a way of substituting the existing verify_client_scope and verify_resowner_scope with this more generic function; but the library can't get the scope from a client or resource-owner because the data structures representing these are defined in the particular back-end implementation.
|
I'm on vacation for another week. Will look and merge after that. Great work! |
|
Great. This is my last big change, the implicit flow can be implemented using oauth2:authorize_password as it is. Have a good time. |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: BREAKS THE COMPATIBILITY WITH PREVIOUS CODE USING oauth2:refresh_acess_token AND PREVIOUS BACKEND IMPLEMENTATIONS.