Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] refactoring entity reflexion to avois duplication #122

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

bim-g
Copy link
Collaborator

@bim-g bim-g commented Aug 30, 2023

There was so much duplication function that are doing exactly the same thing except few difference that could be manage with parameters.

closes #120

@bim-g bim-g added duplicate This issue or pull request already exists enhancement New feature or request labels Aug 30, 2023
@bim-g bim-g added this to the Entity milestone Aug 30, 2023
@bim-g bim-g self-assigned this Aug 30, 2023
Copy link
Collaborator Author

@bim-g bim-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for feadback

controller/homeController.php Outdated Show resolved Hide resolved
@@ -19,7 +22,10 @@ class homeController{
* @return void
*/
function home(){
Redirect::to("/");
$user = new Users();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be visible

Copy link
Collaborator Author

@bim-g bim-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@bim-g bim-g merged commit 632fae6 into master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Refactor entyti structure refactor getEntityRelationLink and getClassDefinition to have only one method
1 participant