New feature: allow to use a p4a fork #940
Conversation
To be neatest and to be easier to find the key
and if so, remove the old p4a installation so the new one can be installed
opacam
force-pushed
the
feature-allow-p4a-forks
branch
from
a8f9c06
to
3583bb2
Compare
| @@ -208,6 +205,12 @@ android.arch = armeabi-v7a | |||
| # Python for android (p4a) specific | |||
| # | |||
|
|
|||
| # (str) python-for-android fork to use, defaults to upstream (kivy) | |||
| #p4a.fork = kivy | |||
There was a problem hiding this comment.
Minor remark: so for now, we're assuming the fork is on github only right?
There was a problem hiding this comment.
Yes, and also we assume that the name of the fork has not changed 😉
There was a problem hiding this comment.
That's more than enough for a first iteration and that probably covers more than 80% of the cases
|
Awesome thanks! I'll give this a try later this week hopefully |
There was a problem hiding this comment.
This is working pretty good!
I tried it with pip3 install --user --upgrade https://github.com/opacam/buildozer/archive/feature-allow-p4a-forks.zip then playing with an existing project buildozer.spec file.
I could verify that it didn't break the default behavior, while I could also clone from a fork. cd .buildozer/android/platform/python-for-android/ and running git remote -v && git branch to verify things were behaving as expected.
Thanks!
|
Oh man, I'm just using it now for testing kivy/python-for-android#1883 |
This PR adds the ability to use any p4a fork. So combined with buildozer.spec file key
p4a.branchit will allows us to test any pull requests ofkivy/python-for-androidusing buildozer. Also, an user could use his own fork/branch of p4a editing two keys from his buildozer.spec file:p4a.forkandp4a.branchto make use of his own fork/branch of p4a.So...in this PR we do:
p4a.forkp4a.branchto proper section (python-for-android)...of course this is not mandatory, it's only to be neatest and to make easier to find the keyNote: The p4a fork it's supposed to have the same name than the the repository from kivy's organization (python-for-android), if that is not the case, don't expect this to work!!!