Update ffmpeg/ffpyplayer versions #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
previously approved these changes
Jun 10, 2022
misl6
reviewed
Jun 12, 2022
|
Are these changes also fixing the |
AndreMiras
reviewed
Jun 13, 2022
Comment on lines
+6
to
7
| version = "v4.3.5" | ||
| url = "https://github.com/matham/ffpyplayer/archive/{version}.zip" |
There was a problem hiding this comment.
I slightly overlooked that change, but don't we usually exclude the v from the version so the package pinning won't have to include it?
So I mean url could be:
url = "https://github.com/matham/ffpyplayer/archive/v{version}.zip"There was a problem hiding this comment.
Yes/no ? Otherwise there is no way to go back to a specific archive if not pinned with a v ?
There was a problem hiding this comment.
🤔 That's a good question.
Pros:
- Users will likely try to pin versions like
ffpyplayer==4.x.x, as they are used to doing the same when installing things via pip (and etc).
Cons:
- We can't pin a specific hash or tag (if that tag is not prepended by
v) without changing the URL
Some personal considerations about it + one extra question:
- Recipes are not expected to work fine between multiple versions of the same package (or at least are not tested), so pinning a specific version of a package that needs a recipe to install should be discouraged IMHO.
- Maybe
ffpyplayeris not the case, but sometimes we need to target a specific tag or hash as a temp workaround (that happened in past with SDL2 and Kivy). - Maybe we should print a WARNING regarding potential unexpected issues while pinning a specific version on a recipe?
BTW, I'm +1 for keeping the v into the version.
There was a problem hiding this comment.
All good point thanks guys, I leave that to you, I'm fine either ways 👍
|
@tito If you're good with the suggestion and then the CI flags it as ✅ , I'm fine with it. |
|
Hi, any reason this cannot be merged? Thanks! |
AndreMiras
force-pushed
the
update-ffmpeg
branch
from
5b5ef37
to
df7395f
Compare
Thanks for the heads up, I've rebased the PR, will merge if the CI is OK |
|
The @brentpicasso do you have a working version of the recipe? |
|
Thanks for checking it. I don't have this building locally. @tito - were you able to get it to build at the time you submitted this PR? |
Hi @AndreMiras ! See: #716 (comment) |
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
|
Thanks @AndreMiras and @misl6 for the quick turnaround on this! |
AndreMiras
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.