Source distribution via Travis #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tito
reviewed
Oct 19, 2018
| cmdclass={'build_ext': build_ext}, | ||
| packages=['jnius'], |
There was a problem hiding this comment.
Does removing all the keys here still work when building -not- source releases? I don't understand the point to create a separate sdist setup
There was a problem hiding this comment.
Sdist means we don't create any wheels, we just release it the same way you can install it from GitHub:
pip install https://github.com/kivy/pyjnius/zipball/master
and separating the keys means I can safely create the source archive and upload it to PyPI with all the classifiers and other metadata in tact. Also it means a GNU/Linux user can install it from PyPI the same way eg. Cython is installed on RPi - compilation is triggered.
It can compile the normal way and even via pip if you run the command from above.
Log:
|
Could you fix the conflict? |
tito
previously approved these changes
Oct 19, 2018
KeyWeeUsr
force-pushed
the
sdist_travis
branch
from
655f068
to
1b6f629
Compare
tito
approved these changes
Oct 19, 2018
This was referenced Oct 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the default
setup.pyalready does various stuff and there are multiple platforms to support, source dist is easy fix until someone might find interesting to do binary dist. I put the sdist into a separate file with some default common values in a dictionary to reuse them in both setup files.On Travis the build is set up, so that when
$PYJNIUS_DEPLOY == 1it builds the source distribution and attempts to upload it to PyPI(currently test server via Travis settings).