[MOBILE-841] Adding Mapbox on single hotel view #1095
Conversation
RobinCsl
requested review from
ferrannp,
tbergquist-godaddy and
lukewalczak
android/app/build.gradle
Outdated
| @@ -186,6 +186,7 @@ dependencies { | |||
| implementation "com.trinerdis.skypicker:logging:0.2.1-SNAPSHOT" | |||
| implementation("com.google.android.gms:play-services-base:$playServicesVersion") | |||
| implementation("com.google.android.gms:play-services-maps:$playServicesVersion") | |||
| compile project(':mapbox-react-native-mapbox-gl') | |||
There was a problem hiding this comment.
Should be implementation.
RobinCsl
force-pushed
the
mapbox-single-hotel
branch
from
b9e65bb
to
0213e95
Compare
RobinCsl
force-pushed
the
mapbox-single-hotel
branch
2 times, most recently
from
3411930
to
01b1c2e
Compare
RobinCsl
force-pushed
the
mapbox-single-hotel
branch
from
9136975
to
d36c5eb
Compare
| @@ -48,6 +48,7 @@ dependencies { | |||
| api "com.trinerdis.skypicker:react-native-maps:$reactNativeMaps-SNAPSHOT" | |||
| api "com.trinerdis.skypicker:react-native-vector-icons:$reactNativeVectorIcons-SNAPSHOT" | |||
| api "com.trinerdis.skypicker:react-native-tooltips:$reactNativeTooltips-SNAPSHOT" | |||
| api "com.trinerdis.skypicker:mapbox-react-native-mapbox-gl:$reactNativeTooltips-SNAPSHOT" | |||
There was a problem hiding this comment.
Should be $reactNativeMapBox and be defined in dependencies.gradle.
RobinCsl
force-pushed
the
mapbox-single-hotel
branch
from
6ca5f08
to
910fea7
Compare
|
For now @lukewalczak is trying to run this on iOS playground and me on Android playground. Both are having problems. We need to fix this before merging it. Actually, I got the same runtime error when running |
lukewalczak
dismissed
their stale review
ios playground doesnt work. On the way to fix it
|
After conversation with @Blackhex we came to conclusion that we cannot just use this library as it is. The RN wrapper uses: But Kiwi app uses |
Which would also mean we have to maintain it. Does not sound like a good option |
|
@RobinCsl can we close this PR for now? I guess we have to wait for new version of mapbox? |
|
Absolutely; here is the PR we need to watch |
Could someone check that it works correctly on Android?