Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Card component #332

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Add Card component #332

merged 2 commits into from
Jan 26, 2023

Conversation

gerak-cz
Copy link
Contributor

@gerak-cz gerak-cz commented Jan 26, 2023

Didn't write any unit test. Not sure there is anything to test on this component.

Added the test from the documentation. However it doesn't really test anything on this component directly.

@gerak-cz gerak-cz requested a review from a team as a code owner January 26, 2023 10:20
@gerak-cz gerak-cz linked an issue Jan 26, 2023 that may be closed by this pull request
Copy link
Contributor

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main motivation for unit-test was to verify that my example in docs works :D So maybe just because of that?

@hrach hrach added feature New feature or request new component labels Jan 26, 2023
@hrach hrach added this to the Q1/2023 milestone Jan 26, 2023
@hrach hrach changed the title Card component Add Card component Jan 26, 2023
@gerak-cz gerak-cz force-pushed the card-component branch 2 times, most recently from c30f24d to efc9183 Compare January 26, 2023 12:36
@gerak-cz gerak-cz requested a review from hrach January 26, 2023 12:36
@gerak-cz gerak-cz force-pushed the card-component branch 2 times, most recently from 85aa172 to 201a4ab Compare January 26, 2023 14:10
@gerak-cz gerak-cz merged commit 06e165c into main Jan 26, 2023
@gerak-cz gerak-cz deleted the card-component branch January 26, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request new component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card component
2 participants