Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize channel names in list numerics #320

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

progval
Copy link
Contributor

@progval progval commented Feb 12, 2022

Closes thelounge/thelounge#4126

Some servers may not write channel names with consistent casing.
For example, Bahamut writes RPL_NAMREPLY using the real case of the channel,
while RPL_ENDOFNAMES uses the case of the client's command.

For example, when joining a channel named #ValTest:

C: join #VALtest
S: :val4!~f@lfbn-idf3-1-1313-105.w92-170.abo.wanadoo.fr JOIN :#VALtest
S: :bitcoin.uk.eu.dal.net 353 val4 = #ValTest :val4 val3 @val2 
S: :bitcoin.uk.eu.dal.net 366 val4 #VALtest :End of /NAMES list.

Closes thelounge/thelounge#4126

Some servers may not write channel names with consistent casing.
For example, Bahamut writes RPL_NAMREPLY using the real case of the channel,
while RPL_ENDOFNAMES uses the case of the client's command.
@ItsOnlyBinary ItsOnlyBinary merged commit 2bc7f40 into kiwiirc:master Feb 17, 2022
@progval progval deleted the normalize-cache-key branch February 17, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Userlist is empty on DALnet channels
3 participants