Update TestCaseRun.tested_by when setting status. Fixes #459

kiwitcms · Sep 2, 2018 · 2a847c4 · 2a847c4
1 parent 200cf3d
commit 2a847c4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/tcms/testruns/models.py b/tcms/testruns/models.py
@@ -315,10 +315,11 @@ class TestCaseRunStatus(TCMSActionModel):
     FAILED = 'FAILED'
     BLOCKED = 'BLOCKED'
     PASSED = 'PASSED'
+    IDLE = 'IDLE'
 
-    complete_status_names = ('PASSED', 'ERROR', 'FAILED', 'WAIVED')
-    failure_status_names = ('ERROR', 'FAILED')
-    idle_status_names = ('IDLE',)
+    complete_status_names = (PASSED, 'ERROR', FAILED, 'WAIVED')
+    failure_status_names = ('ERROR', FAILED)
+    idle_status_names = (IDLE,)
 
     id = models.AutoField(db_column='case_run_status_id', primary_key=True)
     name = models.CharField(max_length=60, blank=True, unique=True)

diff --git a/tcms/testruns/urls/run_urls.py b/tcms/testruns/urls/run_urls.py
@@ -24,5 +24,6 @@
     url(r'^(?P<run_id>\d+)/update/$', views.update_case_run_text,
         name='testruns-update_case_run_text'),
     url(r'^update-assignee/$', views.UpdateAssigneeView.as_view()),
-    url(r'^case-run-update-status/$', views.UpdateCaseRunStatusView.as_view()),
+    url(r'^case-run-update-status/$', views.UpdateCaseRunStatusView.as_view(),
+        name='testruns-update_caserun_status'),
 ]
diff --git a/tcms/testruns/views.py b/tcms/testruns/views.py
@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 
 import json
+from datetime import datetime
 from http import HTTPStatus
 from functools import reduce
 
@@ -956,6 +957,8 @@ def post(self, request):
         for caserun_pk in object_ids:
             test_case_run = get_object_or_404(TestCaseRun, pk=int(caserun_pk))
             test_case_run.case_run_status_id = status_id
+            test_case_run.tested_by = request.user
+            test_case_run.close_date = datetime.now()
             test_case_run.save()
 
         return JsonResponse({'rc': 0, 'response': 'ok'})
diff --git a/tcms/tests/__init__.py b/tcms/tests/__init__.py
@@ -173,6 +173,8 @@ class BaseCaseRun(BasePlanCase):
     def setUpTestData(cls):
         super(BaseCaseRun, cls).setUpTestData()
 
+        # todo: we need a linter to find all places where we get statuses
+        # by hard-coded names instead of class based attribute constants!
         cls.case_run_status_idle = TestCaseRunStatus.objects.get(name='IDLE')
 
         cls.build = BuildFactory(product=cls.product)
@@ -184,7 +186,7 @@ def setUpTestData(cls):
                                       default_tester=cls.tester)
 
         cls.case_run_1, cls.case_run_2, cls.case_run_3 = [
-            TestCaseRunFactory(assignee=cls.tester, tested_by=cls.tester,
+            TestCaseRunFactory(assignee=cls.tester,
                                run=cls.test_run, build=cls.build,
                                case_run_status=cls.case_run_status_idle,
                                case=case, sortkey=i * 10)