Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

532 remove long press and re-arrange buttons #694

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

BPerlakiH
Copy link
Collaborator

Fixes #532
Fixes #474

Re-arranged the buttons, so no long press is needed to access them:

Simulator Screenshot - iPhone 6s iOS 15 0 - 2024-03-17 at 00 23 07

@kelson42 kelson42 force-pushed the 532-remove-long-press-re-arrange-buttons branch from f14a7dd to a19e484 Compare March 17, 2024 11:56
@kelson42
Copy link
Contributor

@BPerlakiH Thank you but:

  • Can you please update the changelog (have move the tickets to 3.3.0)
  • Not sure what you have done actually, so I guess basically there is no impact beside fixing the problem. Is thatbright?

@rgaudin
Copy link
Member

rgaudin commented Mar 18, 2024

  • Not sure what you have done actually, so I guess basically there is no impact beside fixing the problem. Is thatbright?

I don't know if it's bright 😀 but it's in the PR description: Re-arranged the buttons, so no long press is needed to access them

  • Random is moved outside of bar to go to top, next to search
  • tab icon only reacts to single-tap and displays the tab list
  • library icon is moved from menu to bar and avail on single-tap
  • menu icon is added (we now have 7 icons instead of 6) and serves on single-tap what was on long-press-tab-icon

Bookmark icon used to work with single-tap to list bookmarks and long-press to choose to either see bookmarks or add one. That's another hard-to-guess behavior but I #695 fixes it by removing the long-press and having the bookmark-this page action inside the bookmarks drawer

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a user's standpoint although I haven't tested it. @kelson42 does that look OK to you? Do you want a testflight build with those two PRs to test it live?

@kelson42 kelson42 merged commit cc83955 into main Mar 19, 2024
4 checks passed
@kelson42 kelson42 deleted the 532-remove-long-press-re-arrange-buttons branch March 19, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 17.1 Zim list inaccessible Ability to hide/move "random article" button
3 participants