Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #215
This PR is a summary of my findings so far, and a minor fix for iOS, by adding the background processing and audio capabilities to the apps.
So far by using the test TED ZIM file for videos, I have found the following:
iOS:
There are only small issues really:
Other than these 2 issues, it works perfectly, you can scrub, mute, change subtitles, use picture and picture, which properly closes if you leave the page, and even resumes when you go back. The playback (audio) can be continued even on the Lock Screen, which is nice.
Note: strangely, if I opened the link on my phone and started the video in Safari (outside of the Kiwix app), it starts OK without the black screen (sometimes with some initial buffering hick-ups).
Note: it doesn't work properly on the Simulator (well most audio / video usually less than perfect on simulators anyway), but works great on the device.
See a short demo:
https://github.com/kiwix/kiwix-apple/assets/6784320/089efac7-8881-4955-8a33-9d2b5734947c
macOS:
It is somewhat a different story here:
See the screenshots: