Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of replayWorker by removing wombat and wombat workers #1188

Open
Jaifroid opened this issue Jan 2, 2024 · 0 comments
Open

Reduce size of replayWorker by removing wombat and wombat workers #1188

Jaifroid opened this issue Jan 2, 2024 · 0 comments
Labels
backend build Code relating to building, publishing, or maintaining the app dependencies Pull requests that update a dependency file zimit Code relating to the support of Zimit-style archives
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Jan 2, 2024

Following openzim/warc2zim#143, it might be better to include our own copy of wombat and wombat workers as a dependency in this Repo (and downstream in the PWA), rather than relying on the version embedded in sw.js / a.k.a. replayWorker.js. At build time, terser complains that it had to deoptimize the style of replayWorker because it is larger than 500KB. It seems wasteful that it includes an entire copy of wombat (minified) inside it.

@Jaifroid Jaifroid added dependencies Pull requests that update a dependency file backend build Code relating to building, publishing, or maintaining the app zimit Code relating to the support of Zimit-style archives labels Jan 2, 2024
@Jaifroid Jaifroid added this to the v4.1 milestone Jan 2, 2024
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend build Code relating to building, publishing, or maintaining the app dependencies Pull requests that update a dependency file zimit Code relating to the support of Zimit-style archives
Projects
None yet
Development

No branches or pull requests

1 participant