Library reloading on SIGHUP #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
changed the title
veloman-yunkan
force-pushed
the
library_reloading
branch
from
2f24407
to
3e08155
Compare
mgautierfr
requested changes
Nov 29, 2021
mgautierfr
reviewed
Dec 1, 2021
|
We are good. Please rebase-fixup before we merge. |
Note that this enhancement drops the --donottrustlibrary mode.
veloman-yunkan
force-pushed
the
library_reloading
branch
from
fd7f806
to
098e1cf
Compare
|
@mgautierfr Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243 and #502
Depends on kiwix/libkiwix#636
Library reloading updates metadata of existing books, adds new books and/or removes books that are no longer present in the library XML file.