Pass -latomic for architectures that need it #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some architectures, specifically armel, mipsel, m68k & powerpc in Debian, need to explicitly link to atomic. Use meson to see if the target's CPU family is one of those, and if so, pass -latomic to the linker. Tested on armel and mipsel machines to verify passing -latomic works, and on armhf and amd64 to ensure normal builds aren't broken. Fixes #371.
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 57.41% 57.38% -0.03%
==========================================
Files 48 48
Lines 3614 3614
Branches 1815 1809 -6
==========================================
- Hits 2075 2074 -1
- Misses 1536 1537 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
Nothing to say :) |
legoktm
added a commit
that referenced
this pull request
Jul 15, 2020
Same as #372. I originally missed this because meson didn't know about sh4 until recently (c.f. mesonbuild/meson#7359), but this should work fine on older meson versions too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some architectures, specifically armel, mipsel, m68k & powerpc in
Debian, need to explicitly link to atomic.
Use meson to see if the target's CPU family is one of those, and if so,
pass -latomic to the linker.
Tested on armel and mipsel machines to verify passing -latomic works, and
on armhf and amd64 to ensure normal builds aren't broken.
Fixes #371.