New way of building 404 error HTML responses #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
+ Coverage 57.83% 58.31% +0.48%
==========================================
Files 56 56
Lines 3652 3697 +45
Branches 2048 2069 +21
==========================================
+ Hits 2112 2156 +44
- Misses 1539 1540 +1
Partials 1 1
Continue to review full report at Codecov.
|
This was referenced Mar 24, 2022
This was done in preparation for removing the `bookName` and `bookTitle` parameters from `Response::build_404()`, but since the new function could already be put to some use in this commit that was done too.
Instead of passing the `bookName` and `bookTitle` parameters to `Response::build_404()`, `withTaskbarInfo()` is applied to its result when needed. Note, that in `InternalServer::handle_raw()` `withTaskbarInfo()` was not utilized since the results of the `/raw` endpoint are not supposed to be decorated with a taskbar.
The fact that an info message was moved into C++ code is temporary since it will be moved to a message resource file soon.
After this change it's time to say thank you and good-bye to `withTaskbarInfo()`. But it will take a while.
One more instance of `Response::build_404()` & `withTaskbarInfo()` was taken over by `HTTP404HtmlResponse`.
mgautierfr
force-pushed
the
HTTP404HtmlResponse
branch
from
93b7e59
to
ec2e10b
Compare
|
Rebased on master |
mgautierfr
approved these changes
Mar 28, 2022
|
I like the combination concept you introduce with this PR. This create a more cleaner way to create responses. |
|
@veloman-yunkan @mgautierfr Would be great to fix the |
|
I'm on it #735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step on our path to internationalizing kiwix-serve (and making #679 a smaller PR).
The main goal of this PR was to introduce a new eDSL like way of building error responses. Here it is done only for 404 HTML error responses. A couple of further generalizations still remain in #679 because those enhancements were a little too dependent (factually but not conceptually) on the changes related to the internationalization of kiwix-serve.