Made constructor of SuggestionItem public #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Private constructor of SuggestionItem doesn't buy us anything, but poses problems for unit testing.
Codecov ReportBase: 84.98% // Head: 84.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #740 +/- ##
=======================================
Coverage 84.98% 84.98%
=======================================
Files 99 99
Lines 4428 4428
Branches 1921 1921
=======================================
Hits 3763 3763
Misses 664 664
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@mgautierfr Good to merge? |
mgautierfr
approved these changes
Nov 16, 2022
|
CI failing on macos is independent from this PR. I'm merging. |
mgautierfr
added a commit
that referenced
this pull request
Nov 30, 2022
* Optimization ofthe first call to `zim::Archive::iterEfficient` (@veloman-yunkan #724) * Add some documentation to `zim::writer::IndexData` (@mgautierfr #727) * Correctly catch and rethrow exception thrown in worker threads at creation (@mgautierfr #496 #748) * Optimization of `Entry::getItem()` (@veloman-yunkan #732) * Fix declaration of `zim::setICUDataDirectory()` (@MohitMaliFtechiz #733) * Add `zim::Archive::getMediatCount()` (@mgautierfr #730) * Make compilaton of examples optional (@mgautierfr #738) * Add a CI for wasm (@mgautierfr #746) * Make constructor of SuggestionItem public (@veloman-yunkan #740)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private constructor of
SuggestionItemdoesn't buy us anything, but poses problems for unit testing.This PR is needed for kiwix/libkiwix#843