moq-pub #54
Merged
moq-pub #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For http::uri::Uri
Crib a bunch of code from the old moq-warp File source so we can work out which track(s) moofs and mdats belong to
ANNOUNCE a new track namespace, 'foo' and simply wait for everything to time out because we haven't wired up a way to send objects for it yet.
We don't need to clone clients, so no need to wrap everything up like this anymore
Added while debugging async issues, accidentally committed earlier
and everything it contains. Stop short of printing all of the bytes in a State's VecDeque, but expose most everything else for easier troubleshooting.
|
Rebasing this and working through the updates it'll need to get back in sync with the latest from |
For quinn, higher values take precedence over lower values, the inverse of how we had been treating "send order" so far.
Work around relay / quinn bug with send_order / stream priority by only sending streams with the same priority.
|
There are maybe a few things that could still be cleaned up here, but I'm inclined to try to get this merged sooner rather than later to avoid further integration issues. With the latest changes (basically not using prioritization for now), it works again against the latest relay. |
|
Oof, forgot that I do still need to switch over the the JSON catalog. Spent so long poking around in quinn today trying to chase down those panics around prioritization and mutex poisoning I almost forgot about that. |
kixelated
approved these changes
Aug 29, 2023
englishm
commented
Aug 29, 2023
This avoids breaking workflows now that we have another binary in the workspace (`moq-pub`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a little rough around the edges, but I think it's better to get it merged and avoid further drift and integration issues.