Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moq-pub: JSON catalog support, bugfixes #60

Merged
merged 8 commits into from
Sep 5, 2023

Conversation

englishm
Copy link
Collaborator

@englishm englishm commented Aug 30, 2023

Fixes some bugs around subscription handling and adds support for the new JSON catalog format

@englishm
Copy link
Collaborator Author

cc: @zafergurel. Didn't quite get this working yet, but it's a start!

@zafergurel
Copy link
Contributor

@englishm If I can do something to help, please let me know.

@englishm
Copy link
Collaborator Author

Ok, after fixing some bugs around subscriber-sent track ids, this hard-coded catalog works for the particular BBB test video I happen to be using. Next I need to make it actually generate real catalogs dynamically by parsing moov headers.

@englishm
Copy link
Collaborator Author

englishm commented Sep 4, 2023

Since I've learned the player side isn't currently dependent on all of these fields for playback (it actually still reads them from the init segment), I'm less stressed about working out how to parse all of them from the media itself right now.

Planning to thread through some command line args to set the remaining fields and call this good.

Also simplify how we pass around shared config to just use the clap
parsed values directly.
@englishm englishm changed the title WIP: Start on JSON catalog support moq-pub: JSON catalog support, bugfixes Sep 5, 2023
@englishm englishm marked this pull request as ready for review September 5, 2023 16:57
@englishm englishm merged commit 90818ac into kixelated:main Sep 5, 2023
1 check passed
@zafergurel
Copy link
Contributor

I got it working on my machine. Thanks! @englishm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants