Add Dictionary Compression support #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
pld-gitsync
pushed a commit
to pld-linux/php-pecl-zstd
that referenced
this pull request
Mar 17, 2020
031- Warning: zstd_compress: compression level (-1) must be within 1..22 in %s on line %d 032- -1 -- 0 -- false 033- 0 -- 3547 -- false kjdev/php-ext-zstd#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
zstd_compress_usingcdict()andzstd_decompress_usingcdict(). The code is mostly a copy of the example on zstd.I wasn't sure if I should use
uncompress. I thoughtdecompresswould be better as same as the zstd's original function. Let me know if there's any specific reason.Thanks.