Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Przemienniki.net query source updates #710

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

szporwolik
Copy link
Contributor

After initial implementation by @kk7ds (thanks again!) I've fixed some minor items:

  • added parameter to only show working repeaters provided by przemienniki.net API
  • added support for digital repeaters and various other modes provided by przemienniki.net API
  • added possibility do select multiple bands at the same time
  • alphabetically reordered country list in the dropdown

Related to https://chirp.danplanet.com/issues/1369

Notes:

  • band selection is not written into config - the reason is that if we will not show at the main window the previously chosen bands I can expect that some users will be confused about this, instead we will force user to open the modal band selection window each time; BUT 2m and 70cm are always pre-selected, for user convince and to cover most of the use cases
  • the default country is pre-selected to 'pl'; I don't have exact stats data for przemienniki.net, but my guess would be that 8 out of 10 users are from Poland, so this seemed for me as the better option that choosing first country on the list with some minimal user base

This query source is not perfectly tested, but I think I have covered most common use test cases.

@szporwolik szporwolik marked this pull request as draft July 5, 2023 22:08
@szporwolik szporwolik marked this pull request as ready for review July 5, 2023 22:20
@szporwolik
Copy link
Contributor Author

@kk7ds seems that translation files need update, could you please help with that ?

@kk7ds
Copy link
Owner

kk7ds commented Jul 6, 2023 via email

After initial implementation by @kk7ds (thanks!) I've fixed some minor items:
- added parameter to only show working repeaters provided by przemienniki.net API
- added support for digital repeaters
- added possibility do select multiple bands
@kk7ds kk7ds merged commit c8831b3 into kk7ds:master Jul 10, 2023
@kk7ds
Copy link
Owner

kk7ds commented Jul 10, 2023

For reference, you need gettext installed and then just:

make -C chirp/locale clean all

to refresh the translation files any time you add a new marked-for-translation string.

Excellent job, thanks!

@szporwolik
Copy link
Contributor Author

Thanks for help! 👍🏻

@szporwolik szporwolik deleted the Przemienniki.net branch July 10, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants