Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve save_history #88

Open
gwenn opened this issue Oct 20, 2016 · 5 comments
Open

Improve save_history #88

gwenn opened this issue Oct 20, 2016 · 5 comments

Comments

@gwenn
Copy link
Collaborator

gwenn commented Oct 20, 2016

See https://github.com/danburkert/ksql/blob/master/src/main.rs#L199

@Yamakaky
Copy link

Yamakaky commented Nov 4, 2016

I don't understand, it's expected because the two calls don't output the same Error. BTW, since ReadlineError can contain a io::Error, you can do

fs::create_dir_all(history_path.parent().unwrap())
   .map_err(Into::into)
   .and_then(|_| readline.save_history(&history_path))

A better improvement would be to use https://github.com/brson/error-chain. Waiting for rust-lang-deprecated/error-chain#53.

@Yamakaky
Copy link

Yamakaky commented Nov 4, 2016

Waiting for rust-lang-deprecated/error-chain#55 to be merged.

gwenn pushed a commit to gwenn/rustyline that referenced this issue Nov 30, 2018
Make libsqlite3-sys's build script slightly more intelligent.
@walles
Copy link

walles commented Jan 1, 2022

@Yamakaky both rust-lang-deprecated/error-chain#53 and rust-lang-deprecated/error-chain#55 are merged.

Is this ticket still relevant?

@Yamakaky
Copy link

Yamakaky commented Jan 1, 2022

error-chain doesn't seem to be used anymore so no !

@walles
Copy link

walles commented Jan 1, 2022

@gwenn, @Yamakaky says this ticket isn't relevant any more.

Can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants