-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve save_history
#88
Comments
I don't understand, it's expected because the two calls don't output the same Error. BTW, since fs::create_dir_all(history_path.parent().unwrap())
.map_err(Into::into)
.and_then(|_| readline.save_history(&history_path)) A better improvement would be to use https://github.com/brson/error-chain. Waiting for rust-lang-deprecated/error-chain#53. |
Waiting for rust-lang-deprecated/error-chain#55 to be merged. |
Make libsqlite3-sys's build script slightly more intelligent.
@Yamakaky both rust-lang-deprecated/error-chain#53 and rust-lang-deprecated/error-chain#55 are merged. Is this ticket still relevant? |
error-chain doesn't seem to be used anymore so no ! |
See https://github.com/danburkert/ksql/blob/master/src/main.rs#L199
The text was updated successfully, but these errors were encountered: