Adding final_highlight method to Highlighter trait. Issue 726
#727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atchingBracketHighlighter to re-render line without highlighting. Issue kkawakam#726
gwenn
reviewed
Aug 29, 2023
| } | ||
| } | ||
| Borrowed(line) | ||
| } | ||
|
|
||
| fn highlight_char(&self, line: &str, pos: usize) -> bool { | ||
| if pos == 0 || line.len() != pos { |
There was a problem hiding this comment.
Seems wrong to me.
Maybe the following line is the culprit:
Line 790 in 1c4091a
gwenn
reviewed
Aug 29, 2023
| copy.replace_range(idx..=idx, &format!("\x1b[1;34m{}\x1b[0m", matching as char)); | ||
| return Owned(copy); | ||
| // highlight matching brace/bracket/parenthesis if it exists, and this isn't the final render | ||
| if !self.is_final.get() { |
There was a problem hiding this comment.
could have been added on line 127 above:
if line.len() <= 1 || self.is_final().get() {
return Borrowed(line);
|
I like your solution in #729 better. So I'll close this PR if you plan to merge that one. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
final_highlightmethod toHighlightertrait,Updating MatchingBracketHighlighter to re-render line without highlighting
Issue #726
Thank you.