Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from get_video_info endpoint to youtubei (aka innertube) #198

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Transition from get_video_info endpoint to youtubei (aka innertube) #198

merged 5 commits into from
Jun 22, 2021

Conversation

Camelva
Copy link
Contributor

@Camelva Camelva commented Jun 21, 2021

Description

New Client.videoDataByInnertube function which can fetch data about video. Works almost same as (possibly obsolete) get_video_info endpoint, but returns already structured json data without query string intermediary.
Because of that, cheching for response status now impossible, so ErrResponseStatus is pointless, ErrPlayabiltyStatus doing all checking work now.

Sidenote: new playerResponseData was auto-generated and i just noticed some of the field names slightly differs (videoID -> videoId, URL -> Url and so on. Though it seems like these fields aren't used by anything anyways.

Issues to fix

Please link issues this PR will fix:
#196

if no relevant issue, but this will fix something important for reference
, please free to open an issue.

Reminding

Something you can do before PR to reduce time to merge

  • run "make build" to build the code
  • run "make format" to reformat the code
  • run "make lint" if you are using unix system
  • run "make test-integration" to pass all tests

@corny
Copy link
Collaborator

corny commented Jun 21, 2021

Great job! Please check the linter warnings/errors.

@ghost
Copy link

ghost commented Jun 21, 2021

I get a 404 when using this.

@surpassly
Copy link

I get a 404 when using this.

Same to me

@corny corny merged commit d84e58f into kkdai:master Jun 22, 2021
@corny corny mentioned this pull request Jun 22, 2021
@corny
Copy link
Collaborator

corny commented Jun 22, 2021

All tests are green. Please create a new issue if something does not work for you.

@Camelva
Copy link
Contributor Author

Camelva commented Jun 22, 2021

All tests are green. Please create a new issue if something does not work for you.

Apparently, it seems like ciphered videos always return 403 "Access Denied" after decrypting. Available tests don't check this and i found out about this problem occasionally. Currently trying to find solution

Though, still never got 404 status as users above mentioned

@surpassly
Copy link

All tests are green. Please create a new issue if something does not work for you.

Great! thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants