-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2.5 format changes: dissoc
#287
Comments
Noah -- thanks for asking! Yes, I added You can certainly revert that behavior by, as you note, setting the
That way you won't get the constant pairing. Unless you really like that for some reason? Anyway, that was my thinking on this change. It is always hard to decide to change some default value, but in this case I felt that it was really misleading people, and that is exactly the opposite of my goals. |
Cool, that makes a lot more sense, thanks. Maybe noting that in the changelog will prevent further confusion. I think our goals are at cross purposes, which is understandable. Yours is to build a general tool for the community that is semantic and beautiful and mine is to change as little as possible in my company's codebase when updating libraries. I agree that the way I'm not saying you have to be as conservative as the clojure.core team, just want to highlight why someone might want to keep things that are currently working as close as possible when updating. Thanks as always for your work on zprint. |
Thanks for the comment. I've been in exactly your position (though I'm not at present) and I totally understand. That's why I try to always give people a fallback to the "old way" -- when I can. Thanks for reminding me of the consequences of my changes. It is always good to keep an eye on the pain I'm causing people! |
Hey Kim!
In this commit, the formatting for
dissoc
was changed. It seems there wasn't anything specific for it previously, so I don't know how it decided to format (hang I guess?).Here's an example of the change:
Worth noting that
assoc
didn't receive any likewise changes:I don't necessarily think the change is bad but it has added a bunch of changes to our codebase when updating to 1.2.5.
Ideally this wouldn't have changed, but I can add
"dissoc" :none
to our:fn-map
if reverting has implications elsewhere.Thanks so much
The text was updated successfully, but these errors were encountered: