-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed messages #98
Merged
changed messages #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmann
previously approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me - we might want to change a few test to postprocess == FALSE to reduce test time. can be merged if tests run through!
yupp, timed out - we need to address #99 before merging. Test check should definitely not run longer than 60 minutes. |
max-pilz
added a commit
that referenced
this pull request
Feb 21, 2019
* spline interpolation * added n1 penalization * reverted interpolation * typo * plot n properly * Update README.md * Update DESCRIPTION * renamed project file * renaming * adapted test dependencies * fixed Rbuildignore and incomplete rename * fixed tests * updated docs * updated docs * update docs * fixed x labs, changed to proper indxed x_1 * updated vignette * extended minimize output * updated tests and vignette to new minimize output * fixed vignette * reverted vignette * vignette update * change of N1 name and discretization of scores plots * added documentation, fixed issues * updated warnings * removed errors * revising test suit to absolute minimum (#103) * revised test_tunable; only testing absolute minumum; added a few todos for missing cases! * created new test file for minimize() alone and moved nloptr status tests from TwoStageDesigns tests there * moved post processing tests to test_minimize and removed clutter; added todo to include proper test of base case vs. simulated values * updated todos * temporarily removed Vignette from build step; fixed documentation mismatch by rebuilding docs. * added computation of base-case OS/GS/TS designs; still need to be checked for consistency and vs simulated results * fixed ToDos and a bug in minimize() * return error for plotg OneStageDesign * tunable tests and functionality for os- and gs-designs * post-process for one-stage design * tidying up * fixing docs * changed messages (#98) minimize now uses proper status messages from nloptr * autodeploy pkgdown to gh pages * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Docs (#111) * deleted docs/ now on gh-pages branch * avoid timeout during deployment on Travis-CI
max-pilz
added a commit
that referenced
this pull request
Feb 27, 2019
* Basic tests of AffineScore * minor formatting, slightly expanded docs and added one missing test case * typo * added more tests * added missing mass argument * typo * updated docs * brackets removed * updated pkgdown and added logo * added new design tests and started documentation * updated documentation * made n in the hex sticker discrete * updated testing * added score arithmetic tests * spline interpolation * added tests for print and plot * added print test * new figure trial * next trial * added skip to vdiffr test * skipt vdiffr * added n1 penalization * test for printing * print test no 2 * test for plot * splitted print and plto test * generalized constraint syntax * removed plot test * tests for constraint syntax * reverted interpolation * typo * added constraint tests * plot n properly * added basic plot test * correct definition of cp * Update README.md * Update DESCRIPTION * renamed project file * renaming * adapted test dependencies * fixed Rbuildignore and incomplete rename * fixed tests * updated docs * updated docs * update docs * fixed x labs, changed to proper indxed x_1 * updated vignette * extended minimize output * updated tests and vignette to new minimize output * fixed vignette * reverted vignette * vignette update * change of N1 name and discretization of scores plots * added documentation, fixed issues * updated warnings * removed errors * revising test suit to absolute minimum (#103) * revised test_tunable; only testing absolute minumum; added a few todos for missing cases! * created new test file for minimize() alone and moved nloptr status tests from TwoStageDesigns tests there * moved post processing tests to test_minimize and removed clutter; added todo to include proper test of base case vs. simulated values * updated todos * temporarily removed Vignette from build step; fixed documentation mismatch by rebuilding docs. * added computation of base-case OS/GS/TS designs; still need to be checked for consistency and vs simulated results * fixed ToDos and a bug in minimize() * return error for plotg OneStageDesign * tunable tests and functionality for os- and gs-designs * post-process for one-stage design * tidying up * fixing docs * changed messages (#98) minimize now uses proper status messages from nloptr * autodeploy pkgdown to gh pages * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Docs (#111) * deleted docs/ now on gh-pages branch * avoid timeout during deployment on Travis-CI * Testing (#116) increased test coverage * n1/n2/n rounding interface (#119) * kinda got n1/n2 rounding to work - documentation needs to be updated and the optimal designs now look very weird; still buggy. * fixed problem, updated tests and documentation. removed depricated tests -> lower coverage * updated vignette * Split minimize (#120) * kinda got n1/n2 rounding to work - documentation needs to be updated and the optimal designs now look very weird; still buggy. * fixed problem, updated tests and documentation. removed depricated tests -> lower coverage * updated vignette * just starting * sketched postprocess() * Update minimize.R * tests splitted * fixed bugs * included one stage post processing * Split minimize (#127) * kinda got n1/n2 rounding to work - documentation needs to be updated and the optimal designs now look very weird; still buggy. * fixed problem, updated tests and documentation. removed depricated tests -> lower coverage * updated vignette * just starting * sketched postprocess() * Update minimize.R * tests splitted * fixed bugs * included one stage post processing * Split minimize (#120) (#126) * kinda got n1/n2 rounding to work - documentation needs to be updated and the optimal designs now look very weird; still buggy. * fixed problem, updated tests and documentation. removed depricated tests -> lower coverage * updated vignette * just starting * sketched postprocess() * Update minimize.R * tests splitted * fixed bugs * included one stage post processing * Constructor (#128) * first version, tests not working yet * update tests * fixed error * fixed examples * try to solve conflicts * Integrate expected (#130) * changed name integrate -> expected * added some tests * included spline interpolation (#132) * Docs (#134) * deleted docs/ now on gh-pages branch * dont need README.Rmd anymore * Update README.md * added docsearch to gh-pages (#137) added docsearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.