feat: implement 0x13 - SGT Opcode #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snapshot Comparison Report: No changes in gas consumption. |
enitrat
reviewed
Sep 4, 2023
| fn test_exec_sgt() { | ||
| // https://github.com/ethereum/go-ethereum/blob/master/core/vm/testdata/testcases_sgt.json | ||
| assert_sgt( | ||
| 0x0000000000000000000000000000000000000000000000000000000000000000, |
There was a problem hiding this comment.
it would be nice to replace all 0x000...1 by 0x1 and all 0x000..00 by 0x0
crates/evm/src/tests/test_instructions/test_comparison_operations.cairo
Outdated
Show resolved
Hide resolved
ClementWalter
requested changes
Sep 4, 2023
| fn assert_sgt(a: u256, b: u256, expected: u256) { | ||
| // Given | ||
| let mut ctx = setup_execution_context(); | ||
| ctx.stack.push(a).unwrap(); |
There was a problem hiding this comment.
copied SLT style already validated in main , but didn't really understand why... should have asked before.
|
@enitrat @ClementWalter now it should be better ! |
enitrat
reviewed
Sep 4, 2023
added 2 commits
September 4, 2023 17:40
|
@enitrat everything should be ok |
enitrat
reviewed
Sep 4, 2023
ClementWalter
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #8
What is the new behavior?
Implementation of SGT EVM opcode
Does this introduce a breaking change?