Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: account balances #569

Merged
merged 2 commits into from
Nov 27, 2023
Merged

refactor: account balances #569

merged 2 commits into from
Nov 27, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 23, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #565

What is the new behavior?

  • Moved the balance accounting to the Account object

Does this introduce a breaking change?

  • Yes
  • No

fix: test_kakarot_core_compute_starknet_address

chore: update compute sn address script
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 71ddcd6 Nov 27, 2023
4 checks passed
@Eikix Eikix deleted the refactor/account-balances branch November 27, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: move state balances to the account object
2 participants