Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: create opcode #594

Merged
merged 4 commits into from
Nov 29, 2023
Merged

tests: create opcode #594

merged 4 commits into from
Nov 29, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 28, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #454

What is the new behavior?

  • Implemented success and failure tests for the create opcode

Does this introduce a breaking change?

  • Yes
  • No

Eikix
Eikix approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix merged commit 123271d into main Nov 29, 2023
3 of 4 checks passed
@Eikix Eikix deleted the tests/create branch November 29, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement CREATE opcode
2 participants
@enitrat @Eikix