Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetching storage of undeployed CA #639

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: fetching storage of undeployed CA #639

merged 1 commit into from
Dec 11, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Dec 8, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #638

What is the new behavior?

  • Checked if the contract is on SN before calling fetch_storage

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment

Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@enitrat enitrat merged commit 20918ce into main Dec 11, 2023
3 of 5 checks passed
@enitrat enitrat deleted the fix/issue-638 branch December 11, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: interaction with Starknet in sstore
3 participants