Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

1.6.1-geocouch: add Dockerfile FROM couchdb:1.6.1 for geocouch plugin #49

Closed
wants to merge 1 commit into from

Conversation

almereyda
Copy link
Contributor

This pull request commits a Dockerfile for GeoCouch, building upon the couchdb:1.6.1 Docker image and the plugin pattern known from couchdb:1.6.1-couchperuser.

This could probably be integrated into a set of official CouchDB Docker images as of docker-library/official-images#1288

This commit adds a Dockerfile for GeoCouch, building upon the couchdb:1.6.1 Docker image and the plugin pattern known from couchdb:1.6.1-couchperuser
@almereyda
Copy link
Contributor Author

How would I have to add testing, like checking for the expected return in https://github.com/couchbase/geocouch/tree/couchdb1.3.x#using-geocouch?

@klaemo
Copy link
Owner

klaemo commented Feb 16, 2016

🎉 Awesome! This can and should definitely be included in the official image.

Couple of questions:

  • There's no way of building geocouch without the CouchDB source, right?
  • How big is the image in the end?

As for testing: I don't really have testing set up right now, but maybe it's something worth looking into. You could curl in docker-entrypoint.sh to be sure that the couch comes up with the plugin.

@almereyda
Copy link
Contributor Author

  1. I suppose @vmx knew an answer. Let's imagine we had official binary releases of GeoCouch for different CouchDB/Couchbase platforms. I believe generating verified builds of that is a bit out of scope for this PR. Then we'd also only reference the plugin path and copy the tests, no?
  2. The image 12c5547dfc08, currently available at https://hub.docker.com/r/almereyda/geocouch/, wheights 347,6 MB, which is a half more than the couchdb:1.6.1 source with 226,4 MB.
  3. I will try to implement the "test" so we know for sure it's not broken and the build succeeds.

&& curl -fSL https://www.apache.org/dist/couchdb/source/$COUCHDB_VERSION/apache-couchdb-$COUCHDB_VERSION.tar.gz.asc -o couchdb.tar.gz.asc \
&& gpg --verify couchdb.tar.gz.asc \
&& mkdir -p /usr/src/couchdb \
&& tar -xzf couchdb.tar.gz -C /usr/src/couchdb --strip-components=1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you rm couchdb.tar.gz here we can save 12MB. Otherwise it'll get committed to this layer.

@klaemo
Copy link
Owner

klaemo commented Feb 18, 2016

Could you combine fetching couchdb, building geocouch and cleaning up in one big RUN command? That should save same bytes.

@almereyda
Copy link
Contributor Author

Yes, I had another idea tonight involving using ONBUILD commands on a
couchdb-base image and then deleting the source files from the images using
it.

On 18 February 2016 at 15:00, Clemens Stolle notifications@github.com
wrote:

Could you combine fetching couchdb, building geocouch and cleaning up in
one big RUN command? That should save same bytes.


Reply to this email directly or view it on GitHub
#49 (comment).

@klaemo
Copy link
Owner

klaemo commented May 8, 2016

What's the status on this one? :)

@almereyda
Copy link
Contributor Author

Oh, I see #46 has been merged. For me this is tightly coupled with dokku/dokku-couchdb#5 as I need the GeoCouch in a Dokku development environment for https://github.com/TransforMap/data.transformap.co.
I suppose I will have time and energy to look into this next week again?

@klaemo
Copy link
Owner

klaemo commented May 10, 2016

No worries, I was just checking in.

Do it at your own pace :) I would love to get this in the official image, but I'm in no rush.

@willholley
Copy link

@almereyda appreciate this issue hasn't been touched in a while but this repository is moving to https://github.com/apache/couchdb-docker. If you want to continue with the PR, could you reissue it against the new repository?

@almereyda
Copy link
Contributor Author

Hi @willholley, thanks for the information. Let's indeed close here and reissue once appropriate.

@almereyda almereyda closed this Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants