-
Notifications
You must be signed in to change notification settings - Fork 98
1.6.1-geocouch: add Dockerfile FROM couchdb:1.6.1 for geocouch plugin #49
Conversation
This commit adds a Dockerfile for GeoCouch, building upon the couchdb:1.6.1 Docker image and the plugin pattern known from couchdb:1.6.1-couchperuser
How would I have to add testing, like checking for the expected return in https://github.com/couchbase/geocouch/tree/couchdb1.3.x#using-geocouch? |
🎉 Awesome! This can and should definitely be included in the official image. Couple of questions:
As for testing: I don't really have testing set up right now, but maybe it's something worth looking into. You could |
|
&& curl -fSL https://www.apache.org/dist/couchdb/source/$COUCHDB_VERSION/apache-couchdb-$COUCHDB_VERSION.tar.gz.asc -o couchdb.tar.gz.asc \ | ||
&& gpg --verify couchdb.tar.gz.asc \ | ||
&& mkdir -p /usr/src/couchdb \ | ||
&& tar -xzf couchdb.tar.gz -C /usr/src/couchdb --strip-components=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you rm couchdb.tar.gz
here we can save 12MB. Otherwise it'll get committed to this layer.
Could you combine fetching couchdb, building geocouch and cleaning up in one big |
Yes, I had another idea tonight involving using ONBUILD commands on a On 18 February 2016 at 15:00, Clemens Stolle notifications@github.com
|
What's the status on this one? :) |
Oh, I see #46 has been merged. For me this is tightly coupled with dokku/dokku-couchdb#5 as I need the GeoCouch in a Dokku development environment for https://github.com/TransforMap/data.transformap.co. |
No worries, I was just checking in. Do it at your own pace :) I would love to get this in the official image, but I'm in no rush. |
@almereyda appreciate this issue hasn't been touched in a while but this repository is moving to https://github.com/apache/couchdb-docker. If you want to continue with the PR, could you reissue it against the new repository? |
Hi @willholley, thanks for the information. Let's indeed close here and reissue once appropriate. |
This pull request commits a Dockerfile for GeoCouch, building upon the
couchdb:1.6.1
Docker image and the plugin pattern known fromcouchdb:1.6.1-couchperuser
.This could probably be integrated into a set of official CouchDB Docker images as of docker-library/official-images#1288