-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package should autocreate log directory #2
Comments
Absolutely you point is valid. When I did coding for check and folder not exits then add that will make performance down to check folder every sql query call with folder exits or not. So made note on doc. Note:
|
Realistically, the software should do it itself, so it’s one less command to run. Unfortunately, we’re a team of several developers so it’s one more step to our already complex process to get a site running on a new system.
… On Jun 26, 2017, at 2:10 PM, K Laravel ***@***.***> wrote:
@tmaly1980 <https://github.com/tmaly1980>
Absolutely you point is valid.
When I did coding for check and folder not exits then add that will make performance down to check folder every sql query call with folder exits or not.
So made note on doc.
Note:
Make sure defined DB_LOG_DIRECTORY directory should be exists default direcotry is \storage\logs\db\ else application will throw error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHVz2y321w-Hfv2B2o1iOAqS3aDoTdikks5sH_QOgaJpZM4OFT-i>.
|
You are welcome to make pull request and I will merge after verify. |
Here is commit what I did on past for create folder and check but because of performance I have removed. |
It's not mentioned in your instructions, but once installing your package, my app won't load and just gives a 500 error. I have to look into my log files to find out that the dblogger package isn't creating the necessary log folder. It's a bit of a nuisance and one more step that each developer has to remember when installing.
The text was updated successfully, but these errors were encountered: