Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package should autocreate log directory #2

Open
tmaly1980 opened this issue Jun 26, 2017 · 4 comments
Open

Package should autocreate log directory #2

tmaly1980 opened this issue Jun 26, 2017 · 4 comments

Comments

@tmaly1980
Copy link

It's not mentioned in your instructions, but once installing your package, my app won't load and just gives a 500 error. I have to look into my log files to find out that the dblogger package isn't creating the necessary log folder. It's a bit of a nuisance and one more step that each developer has to remember when installing.

@klaravel
Copy link
Owner

@tmaly1980

Absolutely you point is valid.

When I did coding for check and folder not exits then add that will make performance down to check folder every sql query call with folder exits or not.

So made note on doc.


Note:

Make sure defined DB_LOG_DIRECTORY directory should be exists default direcotry is \storage\logs\db\ else application will throw error.

@tmaly1980
Copy link
Author

tmaly1980 commented Jun 26, 2017 via email

@klaravel
Copy link
Owner

You are welcome to make pull request and I will merge after verify.

@klaravel
Copy link
Owner

Here is commit what I did on past for create folder and check but because of performance I have removed.

34b3b53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants