-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: string length expression #72
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
========================================
+ Coverage 72.2% 72.5% +0.2%
========================================
Files 18 18
Lines 3816 3835 +19
========================================
+ Hits 2758 2783 +25
+ Misses 1058 1052 -6
|
@engineerjoe440 mind taking a look before I merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes all look good and seem clear, to me. I won't have a chance to run this up in test until Friday of this week (at the earliest), because I'm helping with a youth conference. But I still think this looks nice! 😃
Ah, no rush - blark is low priority for all involved. :) If you're willing to take a look later I'm happy to wait to merge. I'll be out for about a week starting tomorrow, also. Have fun with the conference! |
Thank you! I'll give it a run-down on Friday. Can't wait! |
Just gave this a quick run and it's looking pretty nice! Thank you, again! |
Context
Closes #70
Building on @engineerjoe440 's branch
Changes
Continuous Integration
Grammar
bracketed_expression
used solely for string lengths as inSTRING[255]
STRING_TYPE
-> is now a rulestring_type_specification
as it must support expressions for length and not just simple integers/constants/terminalsstring_spec_length
added to support both flavors of string type declaration lengthsSTRING[255]
andSTRING(255)
Dataclasses
SimpleSpecification
gets a bit more complicated as its type is no longer just a stringToken
Test suite