Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX/CLN: remove unsupported power_expression #76

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

klauer
Copy link
Owner

@klauer klauer commented Jul 21, 2023

Closes #75

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #76 (a522ef5) into master (11d5c30) will increase coverage by 0.2%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #76     +/-   ##
========================================
+ Coverage    78.1%   78.3%   +0.2%     
========================================
  Files          26      26             
  Lines        5339    5339             
========================================
+ Hits         4171    4184     +13     
+ Misses       1168    1155     -13     
Impacted Files Coverage Δ
blark/tests/test_transformer.py 93.1% <ø> (ø)
blark/transform.py 98.9% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@engineerjoe440 engineerjoe440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I hadn't even stumbled across this in context of any real 61131. I do agree that this is a good fix! 😄

@engineerjoe440 engineerjoe440 merged commit 5f0674a into master Jul 27, 2023
10 checks passed
@engineerjoe440 engineerjoe440 deleted the bugfix/remove_power_expression branch July 27, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-asterisk (**) exponential operator is not supported by TwinCAT
3 participants