FIX: ignore global text list project files #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
GlobalTextList
loading bugProjects with
GlobalTextList
entries in TwinCAT projects would previously raise:RuntimeError: Unsupported xml type for TcSource: <Element TcPlcObject at 0x7f70fc315340>
For one, that exception message has been improved to include a bit more context:
UnsupportedSourceFileError: Unsupported xml type for TcSource: TcPlcObject/GlobalTextList
If loaded directly with the
TcSource.from_filename
utility method, the above will be raised.If loaded as part of a solution/tsproj, the unsupported source file will just be ignored.
Test suite changes
pytest.skip
error when users (or I) accidentally forget to clone recursively.
ofAND iq_stValve. THEN
is syntactically incorrect)