Skip to content

Conversation

tkawachi
Copy link
Member

@tkawachi tkawachi commented Dec 9, 2012

I've created typescript-node gem which just compiles TypeScript with Node.js + tsc command.
It seems that it is working with /// . It will fix #5

@tkawachi
Copy link
Member Author

tkawachi commented Dec 9, 2012

Oops travis-ci complains. I'll check it.

@klaustopher
Copy link
Contributor

Could you please add tests that show that the /// works?

@tkawachi
Copy link
Member Author

tkawachi commented Dec 9, 2012

I'll try.

@klaustopher
Copy link
Contributor

Oh, I forgot: Thanks for the improvement ;) Didn't really have time to work on this and this makes it really usable.

One more question ... Does it check in any way if node.js is available, I didn't see it in any of the dependencies in your node gem, or am I overlooking something?

@tkawachi
Copy link
Member Author

tkawachi commented Dec 9, 2012

It fails on node command execution when invoking Open3.popen3() if there is no node command in PATH.
I don't know a proper place to check command existence. Do you have any advice?

@klaustopher
Copy link
Contributor

I have looked around for a few minutes and couldn't find anything ... So I guess this is the only way to go ... I don't really like it since this requires people to read documentation instead of just dropping in the gem and using it ... Let me think a bit about this.

@tkawachi
Copy link
Member Author

tkawachi commented Dec 9, 2012

I've changed typescript-node-ruby gem to raise a command an error when require "typescript-node" is called if node command is not found. An error message is rather descriptive than before.

typescript-ruby/typescript-node-ruby@6f3cf7f

@sgentile
Copy link

Is this gem updated for references now - it doesn't seem to be working for me

Thanks!
Steve

@klaustopher
Copy link
Contributor

No it isn't ... I think I'll just merge in the requirement for node and we'll use that ...

klaustopher added a commit that referenced this pull request Mar 31, 2013
Use typescript-node gem which can handle /// <reference>
@klaustopher klaustopher merged commit e77ac07 into typescript-ruby:master Mar 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<reference path="..."/> doesn't work
3 participants