This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
[Proposal] Fungible token Standard #7
Merged
KimKyungup
merged 15 commits into
klaytn:master
from
KimKyungup:fungible_token_standard
Feb 24, 2020
Merged
[Proposal] Fungible token Standard #7
KimKyungup
merged 15 commits into
klaytn:master
from
KimKyungup:fungible_token_standard
Feb 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joowon-byun
approved these changes
Feb 20, 2020
kjhman21
reviewed
Feb 20, 2020
kjhman21
reviewed
Feb 20, 2020
kjhman21
reviewed
Feb 20, 2020
Co-Authored-By: Junghyun Colin Kim <Colin.kim@groundx.xyz>
jimni1222
reviewed
Feb 20, 2020
joowon-byun
reviewed
Feb 20, 2020
jimni1222
reviewed
Feb 20, 2020
joowon-byun
reviewed
Feb 20, 2020
Co-Authored-By: Winnie (Joowon) <joowon7508@gmail.com> Co-Authored-By: Jasmine <32922423+jimni1222@users.noreply.github.com>
@kjhman21 @winnie-byun @jimni1222 |
jimni1222
reviewed
Feb 20, 2020
jimni1222
reviewed
Feb 20, 2020
jimni1222
reviewed
Feb 20, 2020
jimni1222
reviewed
Feb 20, 2020
kjhman21
reviewed
Feb 20, 2020
kjhman21
reviewed
Feb 20, 2020
KimKyungup
commented
Feb 20, 2020
Co-Authored-By: Junghyun Colin Kim <Colin.kim@groundx.xyz> Co-Authored-By: Jasmine <32922423+jimni1222@users.noreply.github.com>
@KimKyungup |
jimni1222
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Please check cla and git warning.
kjhman21
reviewed
Feb 21, 2020
kjhman21
reviewed
Feb 21, 2020
kjhman21
reviewed
Feb 21, 2020
Co-Authored-By: Junghyun Colin Kim <Colin.kim@groundx.xyz>
…up/kips into fungible_token_standard
kjhman21
reviewed
Feb 21, 2020
jimni1222
approved these changes
Feb 21, 2020
kjhman21
reviewed
Feb 21, 2020
kjhman21
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Finally! 👍
joowon-byun
approved these changes
Feb 21, 2020
kjhman21
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes fungible token standard of Klaytn.
This standard was derived from ERC-20.
However comparing with ERC-20, this token standard enforces the triggering of transfer events when minting / burning tokens.