Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Add Kore hardfork block to chainConfig & homi #1639

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

ian0371
Copy link
Contributor

@ian0371 ian0371 commented Oct 13, 2022

Proposed changes

  • Add a field ChainConfig.KoreCompatibleBlock
  • homi supports --kore-compatible-blocknumber

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Collaborator

@2dvorak 2dvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ian0371 ian0371 merged commit 7ed33ae into klaytn:dev Oct 13, 2022
@kjeom kjeom added this to the v1.10.0 (Kore) milestone Nov 3, 2022
@blukat29 blukat29 mentioned this pull request Nov 9, 2022
31 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants