This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomee1313
requested review from
blukat29,
ian0371,
hyeonLewis,
hyunsooda,
2dvorak,
kjeom,
JayChoi1736,
sjnam and
aidan-kwon
as code owners
March 27, 2024 00:00
9 tasks
hyeonLewis
reviewed
Mar 28, 2024
hyunsooda
previously approved these changes
Apr 1, 2024
blukat29
reviewed
Apr 1, 2024
ian0371
reviewed
Apr 3, 2024
hyunsooda
previously approved these changes
Apr 4, 2024
hyunsooda
previously approved these changes
Apr 8, 2024
ian0371
previously approved these changes
Apr 8, 2024
It has to be rebased after #2127. |
@yoomee1313 #2127 merged. Rebase please and sorry for the large changeset. |
yoomee1313
force-pushed
the
refactoring-for-kip103
branch
from
April 9, 2024 01:36
4e32829
to
def0f2e
Compare
yoomee1313
force-pushed
the
refactoring-for-kip103
branch
from
April 9, 2024 01:46
def0f2e
to
68436aa
Compare
yoomee1313
force-pushed
the
refactoring-for-kip103
branch
from
April 9, 2024 03:07
dc1c75d
to
8e558ac
Compare
This PR has been rebased. Please take a look. @blukat29 @ian0371 @hyeonLewis @hyunsooda |
hyeonLewis
previously approved these changes
Apr 9, 2024
|
I missed it. Added the import statement of TreasuryRebalanceMock.sol at all.sol.
Correct. I'm planning to put kip103,kip160 contracts altogether in rebalance folder. |
blukat29
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
hyeonLewis
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
Referenced dev...blukat29:klaytn:module-bc-system.