Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Refactoring for kip103 #2121

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Conversation

yoomee1313
Copy link
Contributor

Proposed changes

  • This PR is a refactoring for kip103.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

Referenced dev...blukat29:klaytn:module-bc-system.

hyunsooda
hyunsooda previously approved these changes Apr 1, 2024
blockchain/system/rebalance_test.go Outdated Show resolved Hide resolved
blockchain/system/rebalance_test.go Outdated Show resolved Hide resolved
blockchain/system/constant.go Outdated Show resolved Hide resolved
consensus/istanbul/backend/engine.go Outdated Show resolved Hide resolved
hyunsooda
hyunsooda previously approved these changes Apr 4, 2024
hyunsooda
hyunsooda previously approved these changes Apr 8, 2024
ian0371
ian0371 previously approved these changes Apr 8, 2024
@blukat29
Copy link
Contributor

blukat29 commented Apr 8, 2024

It has to be rebased after #2127.

@blukat29
Copy link
Contributor

blukat29 commented Apr 8, 2024

@yoomee1313 #2127 merged. Rebase please and sorry for the large changeset.

@yoomee1313
Copy link
Contributor Author

This PR has been rebased. Please take a look. @blukat29 @ian0371 @hyeonLewis @hyunsooda

hyeonLewis
hyeonLewis previously approved these changes Apr 9, 2024
@blukat29
Copy link
Contributor

blukat29 commented Apr 9, 2024

  1. Perhaps you didn't modify contracts/contracts/testing/system_contracts/all.sol?
  2. Do you intend to keep kip103 and upcoming kip160 contracts into contracts/contracts/system_contracts/rebalance altogether? If so, I am okay with the file relocation in this PR.

@yoomee1313
Copy link
Contributor Author

Perhaps you didn't modify contracts/contracts/testing/system_contracts/all.sol?

I missed it. Added the import statement of TreasuryRebalanceMock.sol at all.sol.

Do you intend to keep kip103 and upcoming kip160 contracts into contracts/contracts/system_contracts/rebalance altogether? If so, I am okay with the file relocation in this PR

Correct. I'm planning to put kip103,kip160 contracts altogether in rebalance folder.

Copy link
Contributor

@blukat29 blukat29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yoomee1313 yoomee1313 merged commit bb4f0b8 into klaytn:dev Apr 11, 2024
11 checks passed
@yoomee1313 yoomee1313 deleted the refactoring-for-kip103 branch April 11, 2024 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants