This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Implemented KAS repoistory to load contracts data #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
requested review from
aidan-kwon,
ehnuje,
KimKyungup,
kjhman21 and
joowon-byun
as code owners
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-contracts
branch
from
482908f
to
692dfe6
Compare
ehnuje
reviewed
Aug 5, 2020
KimKyungup
reviewed
Aug 6, 2020
KimKyungup
reviewed
Aug 6, 2020
KimKyungup
reviewed
Aug 6, 2020
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-contracts
branch
from
692dfe6
to
1e8e379
Compare
KimKyungup
approved these changes
Aug 6, 2020
KimKyungup
previously approved these changes
Aug 6, 2020
ehnuje
reviewed
Aug 6, 2020
ehnuje
reviewed
Aug 6, 2020
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-contracts
branch
from
b4b0cc2
to
950fa34
Compare
KimKyungup
previously approved these changes
Aug 7, 2020
ehnuje
previously approved these changes
Aug 7, 2020
aidan-kwon
reviewed
Aug 7, 2020
Comment on lines
+130
to
+135
| if isInvalid, err := f.supportsInterface(contract, opts, InvalidId); err != nil { | ||
| logger.Error("supportsInterface is failed", "contract", contract.String(), "blockNumber", blockNumber, "interfaceID", hexutil.Encode(InvalidId[:])) | ||
| return false, err | ||
| } else if isInvalid { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
Is checking for InvalidId mandatory?
There was a problem hiding this comment.
Yes, according to the KIP-13 specification, it is required.
ref: https://kips.klaytn.com/KIPs/kip-13#how-to-query-if-a-contract-implements-kip-13
|
Please, consider another way of executing a contract without |
aidan-kwon
previously approved these changes
Aug 7, 2020
jeongkyun-oh
dismissed stale reviews from aidan-kwon, ehnuje, and KimKyungup
via
6f0026f
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-contracts
branch
from
6fe2202
to
6f0026f
Compare
|
@aidan-kwon Under the circumstance, I will consider |
KimKyungup
previously approved these changes
Aug 10, 2020
aidan-kwon
previously approved these changes
Aug 10, 2020
added 6 commits
August 10, 2020 12:56
jeongkyun-oh
dismissed stale reviews from aidan-kwon and KimKyungup
via
cbbc865
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-contracts
branch
from
6f0026f
to
cbbc865
Compare
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-contracts
branch
from
8e5950d
to
e101e5c
Compare
aidan-kwon
approved these changes
Aug 10, 2020
|
Sorry to bother you, but I resolved conflicts. Please take another look. @ehnuje @KimKyungup |
KimKyungup
approved these changes
Aug 10, 2020
ehnuje
approved these changes
Aug 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)