Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Remove darwin/386 in cross compile scripts #871

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

aidan-kwon
Copy link
Member

Proposed changes

Remove darwin/386 in cross compile scripts since golang doesn't support it from version 1.15

As announced in the Go 1.14 release notes, Go 1.15 drops support for 32-bit binaries on macOS, iOS, iPadOS, watchOS, and tvOS (the darwin/386 and darwin/arm ports). Go continues to support the 64-bit darwin/amd64 and darwin/arm64 ports.

from https://golang.org/doc/go1.15

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@aidan-kwon aidan-kwon merged commit 096799a into klaytn:dev Jan 21, 2021
@aidan-kwon aidan-kwon deleted the 210121-darwin386 branch January 21, 2021 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants