Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Account events #27

Closed
greenlucid opened this issue May 27, 2022 · 1 comment
Closed

Refactor Account events #27

greenlucid opened this issue May 27, 2022 · 1 comment

Comments

@greenlucid
Copy link
Contributor

You could refactor some account events onto a single AccountUpdate that emits accountId and fullStake (either compressed or uncompressed, we'll figure it out)

  • AccountFunded
  • AccountWithdrawn

Sort of related, wallet as a name field is a very bad name. owner is better.
@greenlucid
Copy link
Contributor Author

as I typed this, I realized the rationale for the Account events being different. one only relays the new Account fullStake. the only one relays the new Account fullstake and lets you know withdrawingTimestamp is back at 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greenlucid